Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-2365 - BI-2365 Change Honey to Honey Bee under program Species list #426

Merged
merged 2 commits into from
Nov 5, 2024
Merged

BI-2365 - BI-2365 Change Honey to Honey Bee under program Species list #426

merged 2 commits into from
Nov 5, 2024

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Nov 5, 2024 •
edited by jira bot
Loading

Description

Story: BI-2365

  • Renamed Honey to Honey Bee

Dependencies

  • bi-web release/1.0

Testing

  • Verify Honey Bee is in the species select box when creating a program
  • Create a Honey Bee program and verify it is created without error

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Nov 5, 2024
mlm483
mlm483 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working. It looks like it should work with bi-docker-stack, at any rate, we'll know very quickly if it doesn't.

@mlm483 mlm483 self-assigned this Nov 5, 2024
@mlm483
Copy link
Contributor

mlm483 commented Nov 5, 2024

@nickpalladino my only question is if this is intended to go into v1.0 or v1.1?

@nickpalladino
Copy link
Member Author

@nickpalladino my only question is if this is intended to go into v1.0 or v1.1?

Ya was hoping to get it into v1.0

@nickpalladino nickpalladino merged commit 46d0af6 into release/1.0 Nov 5, 2024
2 checks passed
@nickpalladino nickpalladino deleted the bug/BI-2365 branch November 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davedrp davedrp davedrp approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@mlm483 mlm483

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpalladino @mlm483 @davedrp